-
Notifications
You must be signed in to change notification settings - Fork 462
🐛(frontend) make summary button fixed to remain visible during scroll #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc1ea66 to
9475a1b
Compare
9475a1b to
e16f313
Compare
|
Size Change: +7 B (0%) Total Size: 4.07 MB
|
| $padding={isHover ? 'xs' : '0'} | ||
| $justify="center" | ||
| $position="relative" | ||
| $position="fixed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make it sticky instead ?
| $position="fixed" | |
| $position="sticky" |
If yes, to make it working you will have to set a height here (height: 100vh;):
docs/src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx
Lines 101 to 110 in e16f313
| <Box | |
| $position="absolute" | |
| $css={css` | |
| top: 72px; | |
| right: 20px; | |
| `} | |
| > | |
| <TableContent /> | |
| </Box> | |
| )} |
| $position="fixed" | ||
| aria-label={t('Summary')} | ||
| $css={css` | ||
| right: 30px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you find sticky is nice, you can replace by:
| right: 30px; | |
| top: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is nice !
68dd545 to
54db631
Compare
AntoLC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
54db631 to
5ec90b8
Compare
ensures persistent access to table of contents by fixing button position Signed-off-by: Cyril <c.gromoff@gmail.com>
5ec90b8 to
d96abb1
Compare
Purpose
Ensure the "Summary" button remains visible during user scrolls, especially on long documents
issue : #1578
Proposal